Skip to content

Implement support for keeping shellclients in the multitasking view #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 31, 2025
Merged

Implement support for keeping shellclients in the multitasking view #2275

merged 6 commits into from
Jul 31, 2025

Conversation

@leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Feb 16, 2025 •
edited
Loading

This provides support for keeping a shellclient (the dock) visible in the multitasking view.

Everything one expects currently works. You can launch new apps, switch workspace by clicking on an app on another workspace etc..

Support was added to allow dragging windows to icon groups in the dock.

Goes with elementary/dock#375

Things todo/think about:

  • When multiple instances of an app are open the window overview is shown. That's not really nice as it is right now however I wonder what we should do instead? One option that I came up with: Overlay window overview #2350

Fixes #2071 (at least most of the time, sometimes the user time is a bit outdated but better than main ig)

@leolost2605 leolost2605 mentioned this pull request Feb 16, 2025
Merged
@leolost2605 leolost2605 force-pushed the leolost/keep-in-multitasking-view branch from e99cbb6 to c6eb6ae Compare March 5, 2025 20:07
@leolost2605 leolost2605 force-pushed the leolost/keep-in-multitasking-view branch 7 times, most recently from 60e5c86 to 4d13578 Compare March 27, 2025 17:05
@leolost2605 leolost2605 mentioned this pull request Mar 29, 2025
Open
@leolost2605 leolost2605 force-pushed the leolost/keep-in-multitasking-view branch from 4d13578 to 1764c24 Compare May 30, 2025 18:34
@leolost2605 leolost2605 force-pushed the leolost/keep-in-multitasking-view branch 3 times, most recently from 3035854 to 178c000 Compare July 5, 2025 22:23
@leolost2605 leolost2605 changed the title Initial support for keeping shellclients in the multitasking view Implement support for keeping shellclients in the multitasking view Jul 5, 2025
@leolost2605 leolost2605 marked this pull request as ready for review July 5, 2025 22:27
@leolost2605
Copy link
Member Author

leolost2605 commented Jul 5, 2025 •
edited
Loading

This should be ready for an initial review now together with elementary/dock#375
Lots of testing and feedback would be appreciated :)
Especially testing with different monitor scales and wild monitor transforms like rotations, flips, etc. etc. would be useful since we have to do quite a bunch of coordinates conversion when dropping winows on the dock icon groups

@leolost2605 leolost2605 requested a review from a team July 5, 2025 22:29
lenemter
lenemter approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There are two issues:

  1. Missing X11 support
  2. Window clones have unfocused styles in multitasking view

But we can deal with them later

@leolost2605 leolost2605 force-pushed the leolost/keep-in-multitasking-view branch from 178c000 to 306272c Compare July 11, 2025 15:56
@leolost2605 leolost2605 force-pushed the leolost/keep-in-multitasking-view branch from 722d2dd to 3f39856 Compare July 31, 2025 10:21
@leolost2605
Copy link
Member Author

leolost2605 commented Jul 31, 2025

@lenemter I added support for X here, the other thing I'd like to do in a follow up :)

lenemter
lenemter reviewed Jul 31, 2025
View reviewed changes
lenemter
lenemter reviewed Jul 31, 2025
View reviewed changes
lenemter
lenemter reviewed Jul 31, 2025
View reviewed changes
lenemter
lenemter reviewed Jul 31, 2025
View reviewed changes
@leolost2605 leolost2605 force-pushed the leolost/keep-in-multitasking-view branch from 28ed934 to 1ba00d4 Compare July 31, 2025 10:58
@leolost2605 leolost2605 enabled auto-merge (squash) July 31, 2025 10:58
@leolost2605 leolost2605 disabled auto-merge July 31, 2025 10:58
@leolost2605 leolost2605 enabled auto-merge (squash) July 31, 2025 11:01
@leolost2605 leolost2605 merged commit b89ec3a into main Jul 31, 2025
6 checks passed
@leolost2605 leolost2605 deleted the leolost/keep-in-multitasking-view branch July 31, 2025 11:01
@lenemter lenemter mentioned this pull request Jul 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenemter lenemter lenemter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dock overlapping right-click menu on elementary OS 8 (next)

3 participants

@leolost2605 @lenemter